-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Component] Crash on displaying rich tooltips on Java 17+ #413
Comments
Is this only happening for empty title or empty description? I can't reproduce this in the SVG viewer demo. If this is only happening in those cases, I'd rather throw an exception in the |
With SVG File Viewer I open the folder The titleLabelWidth is calculated in
So |
The fix should address the real issue, which is a 1x1 size of the |
Comment on the new commit: This is still addressing the symptom. It should not be getting to a place where the size is 1x1. The first place to check would be RichTooltipPanelLayout.preferredLayoutSize. The next one would be in RichTooltipManager.showTipWindow or maybe a bit before to track where the size is computed and set on the JRichTooltipPanel. There's a block in lines 205-207 that computes that. |
Hi @kirill-grouchnikov But I can reproduce the problem:
How to reproduce:
|
1. print ehen th problem occur
2. this is a copy of SvgViewer.java to reproduce the issue
3. SvgFileViewPanel with some log
Where do I find |
commit 67b3bf0 |
Still not seeing this. Is this happening for you on other machines with different OS / JVM versions? |
Ah, I see it now with Java 17 |
Ugh, I would consider this a regression introduced in the JDK by this commit, and in particular this line that sets the popup content to the size of 1x1 before Not much I can do in Radiance to work around this except for short-circuiting and not doing anything in the layout pass if the size is 1x1. |
Hi Kirill,
when using SVG File Viewer I get this OfBoundsException. To reproduce try to get the tooltip on an icon at right border.
Version of Radiance (latest development is 6.5-SNAPSHOT) : v5.0.0
Sub-project (Common, Animation, Theming, Component, ...) : component
Version of Java (current minimum is 9) : 17
Version of OS : WIN-10
The issue you're experiencing (expected vs actual, screenshot, stack trace etc)
Stack trace (line numbers not exact, because I add some log traces):
The text was updated successfully, but these errors were encountered: