Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Component] Revisit the class hierarchy of commands and presentation models #447

Closed
kirill-grouchnikov opened this issue May 4, 2023 · 0 comments
Closed

[Component] Revisit the class hierarchy of commands and presentation models #447

kirill-grouchnikov opened this issue May 4, 2023 · 0 comments
Assignees
@kirill-grouchnikov
Labels
7.0 - Karat Release 7.0 - 2024.H1 Breaking change Marking changes that break backwards compatibility

Comments

@kirill-grouchnikov
Copy link
Owner

No description provided.

@kirill-grouchnikov kirill-grouchnikov added Breaking change Marking changes that break backwards compatibility 7.0 - Karat Release 7.0 - 2024.H1 labels May 4, 2023
@kirill-grouchnikov kirill-grouchnikov self-assigned this May 4, 2023
kirill-grouchnikov added a commit that referenced this issue May 4, 2023
@kirill-grouchnikov
Start refactoring the command class hierarchy
5483457 
For #447
kirill-grouchnikov added a commit that referenced this issue May 4, 2023
@kirill-grouchnikov
Clean up ColorSelectorCommand
e82d098 
No longer need to use its own popup menu content model. For #447
kirill-grouchnikov added a commit that referenced this issue May 4, 2023
@kirill-grouchnikov
Start refactoring the command button presentation class hierarchy
c3e9373 
For #447
kirill-grouchnikov added a commit that referenced this issue May 4, 2023
@kirill-grouchnikov
Unifying a few elements in the command class hierarchy
7355a5e 
For #447
kirill-grouchnikov added a commit that referenced this issue May 5, 2023
@kirill-grouchnikov
First pass to migrate away from component customizers for command but…
fc8aa16 
…tons

* Add FitToIcon variants for all core command button presentation states (small, medium, tile, big)
* Add BaseCommand.tag attribute
* Add BaseCommandButtonPresentationModel.sides attribute
* Add CommandButtonFollowColorSchemeIcon implementation that can be used for command button icons that need to be dynamically rendered to follow the color scheme that matches the current transition-aware state of the button
* Convert the ribbon taskbar overflow button to be fully configured by the command and the presentation model, with no component customizer

For #447
kirill-grouchnikov added a commit that referenced this issue May 5, 2023
@kirill-grouchnikov
Second pass to migrate away from component customizers for command bu…
952b7f7 
…ttons

* Remove FIT_TO_ICON button presentation state and replace with BIG_FIT_TO_ICON everywhere it was used
* Also convert ribbon band expand button to be fully configured by the command and the presentation model, with no component customizer

For #447
kirill-grouchnikov added a commit that referenced this issue May 5, 2023
@kirill-grouchnikov
Third pass to migrate away from component customizers for command but…
1399018 
…tons

Convert ribbon gallery scroller / expand buttons, as well as scrollable panel scroll buttons to be fully configured by the command and the presentation model, with no component customizer

For #447
kirill-grouchnikov added a commit that referenced this issue May 12, 2023
@kirill-grouchnikov
Move away from component customizers
36bc6cf 
For #447
kirill-grouchnikov added a commit that referenced this issue May 12, 2023
@kirill-grouchnikov
Remove all component customizers
fd204b6 
For #447
kirill-grouchnikov added a commit that referenced this issue May 13, 2023
@kirill-grouchnikov
Refactor the internals of command buttons
ec172f0 
The newly added `BaseCommandButtonProjection.getPopupMenuPanelProjection()` is used to get the projection for the popup menu panel content. This also allows removing the need to have the `JCommandButton` to know the "difference" between a regular command button and a ribbon application menu button - as well as removing the need for a separate `JColorSelectorCommandButton` extension of `JCommandButton` just to configure its popup content.

For #447
kirill-grouchnikov added a commit that referenced this issue May 14, 2023
@kirill-grouchnikov
Refactor the internal usage of command buttons for the ribbon
9487df9 
For #447
kirill-grouchnikov added a commit that referenced this issue May 21, 2023
@kirill-grouchnikov
More work on command buttons
4c36ebb 
* Refactor the API of `CommandPopupMenuPresentationModel` to use `item` instead of `menu`
* Add `sides` and `horizontalAlignment` to `CommandPopupMenuPresentationModel`
* Update `BaseCommandButtonPresentationModel.getPopupMenuPresentationModel` return type
* Mark `addMenuXYZ` methods of `AbstractPopupMenuPanel` to be protected so that they can be used outside of the `api.common.popup` package

For #447
kirill-grouchnikov added a commit that referenced this issue May 21, 2023
@kirill-grouchnikov
Support fill horizontal alignment
a2d0f45 
* Switch `BaseCommandButtonPresentationModel.horizontalAlignment` from `int` (constants in `SwingUtilities`) to our own `HorizontalAlignment`
* Support `HorizontalAlignment.FILL` in small, medium and tile layout managers

For #447
kirill-grouchnikov added a commit that referenced this issue May 31, 2023
@kirill-grouchnikov
Fit-to-icon button layouts should look at the preferred icon dimensio…
d6bd896 
…n from the presentation model

For #447
kirill-grouchnikov added a commit that referenced this issue May 31, 2023
@kirill-grouchnikov
Remove get/set icon APIs from command button
775c49d 
For #447
kirill-grouchnikov added a commit that referenced this issue May 31, 2023
@kirill-grouchnikov
Remove get/set extra text APIs from command button
2620d36 
For #447
kirill-grouchnikov added a commit that referenced this issue May 31, 2023
@kirill-grouchnikov
Remove get/set text APIs from command button
17e3bbb 
For #447
kirill-grouchnikov added a commit that referenced this issue May 31, 2023
@kirill-grouchnikov
More cleanups
9ec82dc 
* Refactor command button panel to populate its content in the UI delegate
* Remove get/set horizontal alignment APIs from command button

For #447
kirill-grouchnikov added a commit that referenced this issue May 31, 2023
@kirill-grouchnikov
Remove get/set background appearance strategy APIs from command button
ecab4b5 
For #447
kirill-grouchnikov added a commit that referenced this issue Jun 1, 2023
@kirill-grouchnikov
Remove more APIs from command button
4b17e30 
* Content padding
* Horizontal and vertical gap scale factor
* Fire action on rollover

For #447
kirill-grouchnikov added a commit that referenced this issue Jun 1, 2023
@kirill-grouchnikov
Remove more APIs from command button
f3f973c 
* Icon dimension
* Location order kind - replace with consistent support for straight and open sides, adding the missing support for open sides on command buttons

For #447
kirill-grouchnikov added a commit that referenced this issue Jun 1, 2023
@kirill-grouchnikov
Remove more APIs from command button
1597b0a 
* Auto-repeat action
* Auto-repeat intervals

For #447
kirill-grouchnikov added a commit that referenced this issue Jun 1, 2023
@kirill-grouchnikov
Remove button APIs from the command button strip
d978d79 
For #447
kirill-grouchnikov added a commit that referenced this issue Jun 2, 2023
@kirill-grouchnikov
A generic way to reproject a command with a different presentation model
e23d59e 
This allows adding any command to the ribbon taskbar

For #447
kirill-grouchnikov added a commit that referenced this issue Jun 5, 2023
@kirill-grouchnikov
Remove get/set popup placement strategy APIs from command button
dd61168 
* Convert the breadcrumb bar buttons to the recently added `.setPopupIcon` API with a custom implementation that looks at the rollover / popup showing to decide on the arrow direction (further visual tweaks incoming)
* Remove the popup placement strategy APIs from the command button itself

For #447. Fixes #451.
kirill-grouchnikov added a commit that referenced this issue Jun 5, 2023
@kirill-grouchnikov
First phase to remove get/set command button kind
2c35b53 
For #447
kirill-grouchnikov added a commit that referenced this issue Jun 6, 2023
@kirill-grouchnikov
Second phase to remove get/set command button kind
a49aba6 
For #447
kirill-grouchnikov added a commit that referenced this issue Jun 6, 2023
@kirill-grouchnikov
Third phase to remove get/set command button kind
ce4f1fb 
For #447
kirill-grouchnikov added a commit that referenced this issue Jun 9, 2023
@kirill-grouchnikov
Set key tips for ribbon taskbar content at projection time
6572bc2 
For #447
kirill-grouchnikov added a commit that referenced this issue Jun 9, 2023
@kirill-grouchnikov
Remove get/set key tips APIs from command buttons
e9fbc0c 
For #447
kirill-grouchnikov added a commit that referenced this issue Jun 11, 2023
@kirill-grouchnikov
First pass for preferred size of command buttons to work on models
1bd69fa 
Also add `BaseCommandButtonPresentationModel.forceAllocateSpaceForIcon` attribute

For #447
kirill-grouchnikov added a commit that referenced this issue Jun 11, 2023
@kirill-grouchnikov
Extend support for BaseCommandButtonPresentationModel.forceAllocateSp…
dcb169b 
…aceForIcon

For #447
kirill-grouchnikov added a commit that referenced this issue Jun 11, 2023
@kirill-grouchnikov
Second pass for preferred size of command buttons to work on models
abf24fe 
Redirect existing calls that work on command buttons

For #447
kirill-grouchnikov added a commit that referenced this issue Jun 11, 2023
@kirill-grouchnikov
Fix crash on opening the color selector button popup
3f985ea 
For #447
kirill-grouchnikov added a commit that referenced this issue Jun 12, 2023
@kirill-grouchnikov
Clean up recently added command button layout manager APIs
52f71b4 
Convert all usages of getPreferredSize and getPreferredIconSize to the new world

For #447
kirill-grouchnikov added a commit that referenced this issue Jun 16, 2023
@kirill-grouchnikov
Remove popup panel callback APIs from command button
792ed8d 
For #447
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kirill-grouchnikov kirill-grouchnikov

Labels
7.0 - Karat Release 7.0 - 2024.H1 Breaking change Marking changes that break backwards compatibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kirill-grouchnikov