Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Theming] Revisit implementations of older painters #462

Closed
kirill-grouchnikov opened this issue Mar 4, 2024 · 0 comments
Closed

[Theming] Revisit implementations of older painters #462

kirill-grouchnikov opened this issue Mar 4, 2024 · 0 comments
Assignees
Labels
7.5 - Larimar Release 7.5 - 2024.H1 Breaking change Marking changes that break backwards compatibility

Comments

@kirill-grouchnikov
Copy link
Owner

As part of preparation work for #400

Migrate painter implementations such as StandardFillPainter and StandardBorderPainter and all their extending classes to be fraction-based with clearer logic on how they use specific color scheme colors for specific fractions.

This will be a breaking change since this will remove the getXyzColor() from the "standard" painter classes.

@kirill-grouchnikov kirill-grouchnikov added Breaking change Marking changes that break backwards compatibility 7.5 - Larimar Release 7.5 - 2024.H1 labels Mar 4, 2024
@kirill-grouchnikov kirill-grouchnikov self-assigned this Mar 4, 2024
kirill-grouchnikov added a commit that referenced this issue Mar 4, 2024
And clean up the internal color query utilities that added more complexity than necessary. For #462
kirill-grouchnikov added a commit that referenced this issue Mar 4, 2024
For #462 with updated coroutine version dependency in the script files
kirill-grouchnikov added a commit that referenced this issue Mar 4, 2024
And clean up the internal color query utilities that added more complexity than necessary. For #462
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7.5 - Larimar Release 7.5 - 2024.H1 Breaking change Marking changes that break backwards compatibility
Projects
None yet
Development

No branches or pull requests

1 participant