chore: changed http status and error message to be more user-friendly

Signed-off-by: Dmitry Kisler <[email protected]>
kislerdm · Sep 8, 2023 · 9d55528 · 9d55528
1 parent 898f55c
commit 9d55528
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/server/core/ciam/httphandler.go b/server/core/ciam/httphandler.go
@@ -139,8 +139,8 @@ func (c client) validateRequestsQuotaUsage(w http.ResponseWriter, r *http.Reques
 	}
 
 	if quotasUsage.RateDay.Used >= quotasUsage.RateDay.Limit {
-		w.WriteHeader(http.StatusForbidden)
-		_, _ = w.Write([]byte(`{"error":"quota exceeded"}`))
+		w.WriteHeader(http.StatusTooManyRequests)
+		_, _ = w.Write([]byte(`{"error":"daily quota exceeded"}`))
 		c.logger.Printf("quota exceeded for user %s", user.ID)
 		return false
 	}

diff --git a/server/core/ciam/iam_test.go b/server/core/ciam/iam_test.go
@@ -283,8 +283,8 @@ func Test_client_validateRequestsQuotaUsage(t *testing.T) {
 				user:   &User{},
 				writer: &utils.MockWriter{},
 			},
-			wantStatuCode: http.StatusForbidden,
-			wantBody:      []byte(`{"error":"quota exceeded"}`),
+			wantStatuCode: http.StatusTooManyRequests,
+			wantBody:      []byte(`{"error":"daily quota exceeded"}`),
 			want:          false,
 		},
 		{