Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CIAM #71

Merged
merged 89 commits into from
Sep 7, 2023
Merged

Add CIAM #71

merged 89 commits into from
Sep 7, 2023

Conversation

kislerdm
Copy link
Owner

@kislerdm kislerdm commented Sep 3, 2023

What changed

Server

  • Added ciam package
  • Changed http handles to follow the middleware chain pattern
  • Fixed openAPI response parsing and deserialization

Why do we need it

  • To introduce authN/Z layer and provide extended functionality to registered users
  • To improve codebase maintenance
  • To fix usability

Followup

  • Add client side logic to enable users registration and the auth flow for registered users
  • Improve the email structure (css) to share one-time secret

server/core/ciam/smtp.go Outdated Show resolved Hide resolved
server/core/pkg/postgres/postgres.go Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #71 (a5d15c5) into master (d47f7b2) will increase coverage by 11.75%.
The diff coverage is n/a.

❗ Current head a5d15c5 differs from pull request most recent head 8faf6fa. Consider uploading reports for the commit 8faf6fa to get more accurate results

@@             Coverage Diff              @@
##           master       #71       +/-   ##
============================================
+ Coverage   88.24%   100.00%   +11.75%     
============================================
  Files          15         1       -14     
  Lines        1548        66     -1482     
============================================
- Hits         1366        66     -1300     
+ Misses        152         0      -152     
+ Partials       30         0       -30     
Flag Coverage Δ
cmd-httpserver ?
pkg-gcpsecretsmanager ?
pkg-httpclient 100.00% <ø> (ø)
pkg-openai ?
pkg-postgres ?
root ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 13 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Dmitry Kisler <[email protected]>
Signed-off-by: Dmitry Kisler <[email protected]>
Signed-off-by: Dmitry Kisler <[email protected]>
Signed-off-by: Dmitry Kisler <[email protected]>
Signed-off-by: Dmitry Kisler <[email protected]>
Signed-off-by: Dmitry Kisler <[email protected]>
Signed-off-by: Dmitry Kisler <[email protected]>
Signed-off-by: Dmitry Kisler <[email protected]>
Signed-off-by: Dmitry Kisler <[email protected]>
Signed-off-by: Dmitry Kisler <[email protected]>
Signed-off-by: Dmitry Kisler <[email protected]>
Signed-off-by: Dmitry Kisler <[email protected]>
Signed-off-by: Dmitry Kisler <[email protected]>
Signed-off-by: Dmitry Kisler <[email protected]>
Signed-off-by: Dmitry Kisler <[email protected]>
Signed-off-by: Dmitry Kisler <[email protected]>
Signed-off-by: Dmitry Kisler <[email protected]>
Signed-off-by: Dmitry Kisler <[email protected]>
Signed-off-by: Dmitry Kisler <[email protected]>
Signed-off-by: Dmitry Kisler <[email protected]>
refactoring+cleanup

Signed-off-by: Dmitry Kisler <[email protected]>
Signed-off-by: Dmitry Kisler <[email protected]>
chore: refactoring

Signed-off-by: Dmitry Kisler <[email protected]>
Signed-off-by: Dmitry Kisler <[email protected]>
Signed-off-by: Dmitry Kisler <[email protected]>
Signed-off-by: Dmitry Kisler <[email protected]>
fix: uniqueness check in the query for WriteOneTimeSecret.

Signed-off-by: Dmitry Kisler <[email protected]>
…ss for a user who has not confirmed email yet

Signed-off-by: Dmitry Kisler <[email protected]>
Signed-off-by: Dmitry Kisler <[email protected]>
chore: cleanup.

Signed-off-by: Dmitry Kisler <[email protected]>
Signed-off-by: Dmitry Kisler <[email protected]>
@kislerdm kislerdm merged commit 91ca694 into master Sep 7, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants