Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add authN token refresh #73

Merged
merged 4 commits into from
Sep 8, 2023
Merged

Add authN token refresh #73

merged 4 commits into from
Sep 8, 2023

Conversation

kislerdm
Copy link
Owner

@kislerdm kislerdm commented Sep 8, 2023

What changed

Client

  • Added token refresh logic in the client
  • Fixed authN when triggering generation using keyboard's key combination (ctr+enter)

Server

  • Adjusted response status code and error msg

Why do we need it

  • UX improvement

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #73 (524bdfc) into master (1d54615) will increase coverage by 0.71%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
+ Coverage   74.74%   75.46%   +0.71%     
==========================================
  Files          23       24       +1     
  Lines        2257     2323      +66     
==========================================
+ Hits         1687     1753      +66     
  Misses        452      452              
  Partials      118      118              
Flag Coverage Δ
cmd-httpserver ∅ <ø> (∅)
pkg-gcpsecretsmanager 77.35% <ø> (ø)
pkg-httpclient 100.00% <ø> (?)
pkg-openai 89.62% <ø> (ø)
pkg-postgres 78.60% <ø> (ø)
root 71.51% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
server/core/ciam/httphandler.go 50.93% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

📢 Have feedback on the report? Share it here.

Signed-off-by: Dmitry Kisler <[email protected]>
@kislerdm kislerdm merged commit 51a53ee into master Sep 8, 2023
15 checks passed
@kislerdm kislerdm deleted the fix/webclient-auth-flow branch September 8, 2023 08:51
Copy link
Collaborator

@tz3 tz3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants