Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow importlib-metadata 6.x #424

Merged
merged 1 commit into from
Apr 22, 2023
Merged

allow importlib-metadata 6.x #424

merged 1 commit into from
Apr 22, 2023

Conversation

reaperhulk
Copy link
Contributor

I'm not actually sure if this works, but the 3.7 CI jobs should hopefully show whether this is safe 😄

@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (da2d660) 81.29% compared to head (a857a4c) 81.29%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #424   +/-   ##
========================================
  Coverage    81.29%   81.29%           
========================================
  Files           10       10           
  Lines          770      770           
========================================
  Hits           626      626           
  Misses         144      144           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kislyuk
Copy link
Owner

kislyuk commented Apr 21, 2023

Thanks. I'm seeing an issue in Python 3.7 CI, but I'm not certain that it's related to importlib-metadata. Need to investigate.

@reaperhulk
Copy link
Contributor Author

Yeah, it appears there's a failure that also occurs in 5.x (as you filed an issue about it in #420)

@kislyuk kislyuk merged commit 7676bd6 into kislyuk:develop Apr 22, 2023
@kislyuk
Copy link
Owner

kislyuk commented Apr 22, 2023

OK, Python 3.7 is EOL soon anyway so I've marked these tests as skip as well.

Released in v3.0.6. If anyone sees any issues with importlib_metadata > 4 on Python 3.7, please let me know and we can troubleshoot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants