Fully migrate to pyproject.toml #500
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split from kislyuk#474
kislyuk
requested changes
Aug 10, 2024
| setup( | ||
| url="https://github.com/kislyuk/argcomplete", | ||
| packages=find_packages(exclude=["test", "test.*"]), | ||
| package_data={"argcomplete": ["bash_completion.d/_python-argcomplete", "py.typed"]}, |
There was a problem hiding this comment.
It looks like package_data is not migrated
There was a problem hiding this comment.
You don't need it due to setuptools_scm AFAIK.
There was a problem hiding this comment.
That doesn't make any sense. setuptools_scm manages the version, package_data manages including non-Python files in the distribution.
There was a problem hiding this comment.
It also includes a hook for include_package_data, which is enabled by default in pyproject.toml projects, which includes all files tracked by Git unless otherwise excluded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #474