Changes to be committed: #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: CMakeLists.txt modified: README.md modified: cmake/Modules/gnuradio-radarConfig.cmake modified: lib/CMakeLists.txt modified: lib/scatter_plot.h modified: python/radar/CMakeLists.txt modified: python/radar/__init__.py modified: python/radar/bindings/CMakeLists.txt new file: python/radar/bindings/bind_oot_file.py modified: python/radar/bindings/python_bindings.cc
|
I don't have merge powers here, so someone who does will have to come along. I don't think I see anything in here that I would object to, but it might help to break this up into a few smaller PRs for review purposes. One necessary change would be to remove the It's also unclear to me from the GitHub changed files summary whether the header files are being moved (as desired) or a duplicate set is being added, but I suspect the latter. |
|
Thank you, @ryanvolz. I've mode the modifications as Ryan's suggestions. Following the example of GNU Radio gr-modtool. I've moved the header files form the original location at include/radar to include/gnuradio/radar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modified the file structure and cmake files to migrate to version 3.10.
modified: CMakeLists.txt
modified: README.md
modified: cmake/Modules/gnuradio-radarConfig.cmake
modified: lib/CMakeLists.txt
modified: lib/scatter_plot.h
modified: python/radar/CMakeLists.txt
modified: python/radar/init.py
modified: python/radar/bindings/CMakeLists.txt
new file: python/radar/bindings/bind_oot_file.py
modified: python/radar/bindings/python_bindings.cc