This repository has been archived by the owner on Oct 28, 2024. It is now read-only.
Feature edit annotation messages
#170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the CustomButtonDialog should be refactored at some day; it evolved to kind of a god-class over time. Probably using inharitance to get rid of lots of checks inside the logic might help a lot 🤔 |
dfuchss
reviewed
Apr 6, 2022
...c/edu/kit/kastel/eclipse/grading/view/listeners/AssessmentMarkerViewDoubleClickListener.java
Outdated
Show resolved
Hide resolved
...ipse.grading.view/src/edu/kit/kastel/eclipse/grading/view/assessment/ArtemisGradingView.java
Outdated
Show resolved
Hide resolved
...ipse.grading.view/src/edu/kit/kastel/eclipse/grading/view/assessment/CustomButtonDialog.java
Outdated
Show resolved
Hide resolved
Small changes as requested by dfuchss
dfuchss
approved these changes
Apr 9, 2022
Comment on lines
+34
to
+35
| if (event.getSelection()instanceof TreeSelection selection) { | ||
| if (selection.getFirstElement()instanceof MarkerItem item) { |
There was a problem hiding this comment.
I'll change our formatter here .. :D
There was a problem hiding this comment.
Nevermind .. it's a bug :( diffplug/spotless#1046
dfuchss
suggested changes
Apr 9, 2022
...ipse.grading.view/src/edu/kit/kastel/eclipse/grading/view/assessment/CustomButtonDialog.java
Outdated
Show resolved
Hide resolved
dfuchss
approved these changes
Apr 9, 2022
|
Thx a lot :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.