-
Notifications
You must be signed in to change notification settings - Fork 7
Feature
edit annotation messages
#170
Feature
edit annotation messages
#170
Conversation
I think the CustomButtonDialog should be refactored at some day; it evolved to kind of a god-class over time. Probably using inharitance to get rid of lots of checks inside the logic might help a lot 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good! Thx for the feature. I had very minor comments :)
We'll test the feature asap that we can include it into the grading session of this term.
...c/edu/kit/kastel/eclipse/grading/view/listeners/AssessmentMarkerViewDoubleClickListener.java
Outdated
Show resolved
Hide resolved
...ipse.grading.view/src/edu/kit/kastel/eclipse/grading/view/assessment/ArtemisGradingView.java
Outdated
Show resolved
Hide resolved
...ipse.grading.view/src/edu/kit/kastel/eclipse/grading/view/assessment/CustomButtonDialog.java
Outdated
Show resolved
Hide resolved
Small changes as requested by dfuchss
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good ; I'll modify our formatter since the java 17 features are not nicely integrated
if (event.getSelection()instanceof TreeSelection selection) { | ||
if (selection.getFirstElement()instanceof MarkerItem item) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll change our formatter here .. :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind .. it's a bug :( diffplug/spotless#1046
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found some issue
...ipse.grading.view/src/edu/kit/kastel/eclipse/grading/view/assessment/CustomButtonDialog.java
Outdated
Show resolved
Hide resolved
Thx a lot :) |
No description provided.