-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linking pages to the following structural element not possible if the elements are not on the same hierarchical level #5457
Comments
As far as I know this is not a bug but by design. @oliver-stoehr can you elaborate on this a little more? |
Hi Arved, thanks for your reply. Maybe to clarify my point: if this behaviour is not due to configurations made in the ruleset or elsewhere, it has to be considered a bug imho. Take a look at the contents of the aforementioned book: On page 100 both chapter "II. Halbtageswanderungen" and sub-chapter "e) Ins Bergische" end (and actually "2. Größere Wanderungen..." as well, but I ignored that level), and the following chapter "III. Weitere Tagesausflüge..." begins. |
I would also think that a page should always be assignable to the next structural element, independent of the hierarchical level. This is necessary to enable exporting complete structures (e.g. as PDF) without having to decide if a page is only belonging to the previous chapter or the new main chapter. While investigating this issue i also encountered, that the gallery is duplicating images, when, "assign to next element" is selected multiple times. This does not seem to affect data, so it is only a minor annoyance. Kitodo.Production.-.Profil.1.Microsoft.Edge.2022-11-25.19-15-27.mp4 |
I also opened a general discussion here: |
This restriction is by design. I don't fully remember the reasons we had three years ago. As far as I can tell there are no technical limitations left, that prevent a change of the current implementation.
When linking page 2 in this example, it is not clear whether the "next element" is Chapter 1 or Chapter 2. So it might result in:
or:
|
@oliver-stoehr thanks a lot for your response. In my opinion the next element is chapter 2, because i do not really see the ambiguity here. Everything which is included in chapter 1.1 is automatically part of chapter 1 since the structure-page-link is repeated in the higher hierarchical levels when exporting. |
I found a way to solve this, but it's quite the hassle. So instead of classifying this a bug, making linking between structural elements easier would be my feature request. Here is how I did it:
@oliver-stoehr Thanks for the reply. I can see how there is in theory room for ambiguity here, but I agree with @BartChris that this would very rarely be the case. And only by allowing links across structural levels correct structural data are possible for all the common cases. where structural elements end and begin on the same page and where there is more than one level of structuration depth. solvingLinks.mp4 |
We still see this as a desirable feature. I will try to outline what a solution might look like.
The problems addressed here #5457 (comment) are not a real problem in this context. The example indicates that it might be unclear whether the user wants to link Page 2 in chapter 1.1 to chapter 1 or chapter 2. But a page on chapter 1.1 is always already linked to chapter 1 in the exported METS. So there is no need to explicitly link Page 2 to chapter 1, this always happens automatically. (We might even duplicate the link in the exported METS if we link Page 2 explicitly to chapter 1) I will try to visualize the proposed idea. Consider the following structure from above
Selecting "Assign to next element" for
If the user wants to link
This is necessary to enable explicit linking to sub chapters (sub-structures) as well. The main questions would be My intuition would be: After the initial link element is placed nothing should be explicitly disallowed if it does not bring serious harm from a technical side. This is especially true for b) All page can be dragged around by this user even if this leads to strangely arranged page links. Otherwise we would have to always check whether a specific re-arrangement of pages leads to an illogical linking structure. On the other hand: It is already possible to drag around linked elements but the behavior is sometimes not really predictable. If freely dragging around leads to complicated behavior one can also think of a command like "move link down" or "move link up" to attach the link to sub chapters. This would enable more controlled behavior and would satisfy our requirements. |
I am not sure if the current design choices meet the DFG requirements for 2.3 Linking of logical and physical structure (mets:structLink) of the DFG profile METS application profile for digitised media Version 2.3.1. "A logical structure can be made up from several physical structural elements (e.g. pages) and a physical structure can belong to several logical structural elements." (p. 16) https://dfg-viewer.de/fileadmin/groups/dfgviewer/METS_application_profile_2.3.1.pdf I would also like to add some examples for which there were problems with the input of elements in the structure tree. Pages are missing in the structure tree which could lead to incomplete mets:structLink and incomplete PDF chapter/element download.
So far I have only tested monographs. Is it possible to create a nested structure tree of a journal: Level 1 Journal, Level 2 Volume, Level 3 Issue, Level 4 Journal Article, Level 5 Image? |
@anspallek This should already be possible, because Kitodo automatically adds the links to the higher levels during export. If a page belongs to structure 1.1.1, it also belongs to 1.1 and 1 in the exported METS. It might appear in the editor as if the image is only is attached to the lowest hierarchy level. And this is also the case for the internal METS saved by Kitodo. The exported METS however contains links between the pyhsiycal structure and all the logical level it belongs to (direct or indirect). The DFG guideline
should therefor be satisfied. You can try the "Export DMS" (which generates the exported METS) functionality to check this. |
Hi everyone, could you check the demo video of my pull request (see #6255), and verify that this is the behavior that you expected? Thank you! |
Describe the bug
Not entirely sure whether this is a matter of configuration or an issue of Kitdo itself. Here's the scenario: If you create more than one level of structural data, linking a page at the end of a structure element to the following one does not work if the following element is not on the same hierarchical level.
To Reproduce
To illustrate:
On the last page of the last section (Abschnitt) both the chapter and section end and the following chapter (Kapitel) begins. The page looks like this:
While it worked for all the sections on the same structural level, creating a link to add this page to the following chapter is not a given option in the context menu:
Expected behavior
It should be possible to create a link that adds the current page to the following structural element
Release
3.4.4
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: