Let the ruleset module know about metadata #4329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthias-ronge
force-pushed
the
metadata-in-ruleset
branch
from
c001166
to
4da7131
Compare
This makes a lot of things easier and more understandable in the code, and is a prerequisite for further development. In the past, it was first decided to make the individual modules independent of another, which also means that the ruleset module was independent of the metadata that it processed. In the meantime, that has become more relaxed, metadata is part of the API and can be used in modules. So, this now introduces metadata into rule set modules, makes it easier to use and more understandable, and gets rid of complicated type parameters. In the future, it can also be resolved that complex metadata could not be mapped if not defined in the ruleset, because the ruleset module could not be aware of it. Now it is, so that this problem, too, is easy to solve in a continuation of this development.
matthias-ronge
force-pushed
the
metadata-in-ruleset
branch
from
4da7131
to
2243fc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past, it was first decided to make the individual modules independent of another, which also means that the ruleset module was independent of the metadata that it processed. In the meantime, that has become more relaxed, metadata is part of the API and can be used in modules. So, this now introduces metadata into ruleset module. This makes a lot of things easier and more understandable in the code, and is a prerequisite for further development. It also gets rid of complicated type parameters.
In the future, it can also be resolved that complex metadata could not be mapped if not defined in the ruleset, because the ruleset module could not be aware of it (#3762). Now it is, so that this problem, too, is easy to solve in a follow-up to this pull request.