Fix serial migration #4356
Merged
Fix serial migration #4356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code improvements
|
The tests were successful:
|
solth
reviewed
Apr 22, 2021
| private void checkTaskAndId(Process parentProcess) throws IOException { | ||
| URI parentMetadataFilePath = fileService.getMetadataFilePath(parentProcess, true, true); | ||
| Workpiece workpiece = ServiceManager.getMetsService().loadWorkpiece(parentMetadataFilePath); | ||
| ImportService.checkTasks(parentProcess, workpiece.getRootElement().getType()); |
There was a problem hiding this comment.
If the method checkTasks is required here as well (and not just during import), wouldn't it make sense to move that method from ImportService to WorkflowControllerService or ProcessService?
| @Test | ||
| public void testHierarchyMigration() throws DAOException, ProcessGenerationException, CommandException, | ||
| DataException, IOException, SAXException, ParserConfigurationException { | ||
| HierarchyMigrationTask hierarchyMigrationTask = new HierarchyMigrationTask(Arrays.asList(project)); |
There was a problem hiding this comment.
Suggested change
| HierarchyMigrationTask hierarchyMigrationTask = new HierarchyMigrationTask(Arrays.asList(project)); | |
| HierarchyMigrationTask hierarchyMigrationTask = new HierarchyMigrationTask(Collections.singletonList(project)); |
|
|
||
| import java.io.File; | ||
| import java.io.IOException; | ||
| import java.util.Arrays; |
There was a problem hiding this comment.
Suggested change
| import java.util.Arrays; | |
| import java.util.Collections; |
| } | ||
|
|
||
| private static void createTestMetaAnchorfile() throws Exception { | ||
| List<String> lines = Arrays.asList("<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?>\n" |
There was a problem hiding this comment.
Suggested change
| List<String> lines = Arrays.asList("<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?>\n" | |
| List<String> lines = Collections.singletonList("<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?>\n" |
| } | ||
|
|
||
| private static void createTestMetafile() throws Exception { | ||
| List<String> lines = Arrays.asList("<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?>\n" |
There was a problem hiding this comment.
Suggested change
| List<String> lines = Arrays.asList("<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?>\n" | |
| List<String> lines = Collections.singletonList("<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?>\n" |
solth
reviewed
Apr 22, 2021
Kitodo/src/test/java/org/kitodo/production/helper/tasks/HierarchyMigrationTaskIT.java
Outdated
Show resolved
Hide resolved
…chyMigrationTaskIT.java Co-authored-by: Arved Solth <[email protected]>
solth
approved these changes
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4270
resolves #4268
fix #4267