Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused part of the image management interface #5683

Merged
merged 3 commits into from
Feb 26, 2024

Conversation

matthias-ronge
Copy link
Collaborator

Part of #5580

@matthias-ronge
Copy link
Collaborator Author

@solth Is there a reason why this hasn't been merged yet?

@solth
Copy link
Member

solth commented Jan 10, 2024

@matthias-ronge sorry for not merging this pull request, yet. I just wanted review it and make sure we do not need this code anymore. I will try to review it this week.

Copy link
Member

@solth solth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can see the changes look correct. However, the name of the SQL file needs to be updated to reflect the state of migration files in the current master branch.

Also, please rebase your branch against the current master.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename this file, as the most current SQL migration in the master is now already at number 126!

@solth solth merged commit ad2e804 into kitodo:master Feb 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants