Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make individual terms in process properties searchable #5685

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

BartChris
Copy link
Collaborator

@BartChris BartChris commented Jun 2, 2023

The long term concept for improving metadata search in Kitodo production is to use the metadata of a process (which seems to be already indexed) to search for a process by its metadata.

see: #3512

Right now the properties can be used for searching, but the current configuration of the search requires that the search query to exactly match the content of a property because it targets the keyword subfield of the property. It is therefor not possible to search e.g. for only a part of a title. There is also no normalization applied, so that the query must match exactly what's in the field. This makes the search not really useful in my opinion.

In order to give a little better search experience i propose to enable searching also for parts of a property, e.g. parts of a title, by removing the "keyword"-setting.

@BartChris BartChris changed the title Make indidual terms in process properties searchable Make individual terms in process properties searchable Jun 2, 2023
@solth solth requested a review from oliver-stoehr June 5, 2023 08:44
@solth solth added the feature label Jul 8, 2023
Copy link
Collaborator

@oliver-stoehr oliver-stoehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me.
I observed one limitation: It is only possible to search for parts of a property that are individual words. For example, when searching for "test" it is possible to find "test one" and "test two", but not "testOne" or "testTwo".

In my opinion it might be a good extension of this feature to find all substrings like the before mentioned. But that should be part of a another, future development.

@solth solth merged commit 115fdde into kitodo:master Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants