Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print comments onto docket #5747

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Conversation

oliver-stoehr
Copy link
Collaborator

@oliver-stoehr oliver-stoehr commented Aug 10, 2023

Print comments onto the docket instead of the old, unused 'wikifield'.

To test this, make sure you have the updated docket.xsl in your local directory. Then use the "print docket" button (printer icon) in the process list on any process with at least one comment.

@solth solth added the bug label Aug 10, 2023
Copy link
Member

@solth solth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and comments are now output to the docket correctly again! 👍

@solth
Copy link
Member

solth commented Sep 8, 2023

From my perspective this looks good, but I am not sure if the old wikiField property of Process.java still needs to be taken into account as well. There is no functionality in Kitodo 3 to write any comments to this field anymore, but maybe this is still required for old processes migrated from Kitodo 2.x?

@solth
Copy link
Member

solth commented Sep 27, 2023

@kitodo/kitodo-community-board do you think we still need to consider the old "wikifield" from processes migrated from Kitodo 2.x? Or is it unlikely to still print dockets with metadata for those old processes?

@solth solth merged commit 99e97da into kitodo:master Oct 18, 2023
2 checks passed
@oliver-stoehr oliver-stoehr deleted the comments-docket branch August 7, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants