Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hibernate search] Remove test for indexing #5783

Merged
merged 4 commits into from
Nov 17, 2023

Conversation

matthias-ronge
Copy link
Collaborator

@matthias-ronge matthias-ronge commented Sep 13, 2023

Issue #5760 1a)

@matthias-ronge matthias-ronge changed the title Remove test for indexing [hibernate search] Remove test for indexing Sep 13, 2023
@matthias-ronge
Copy link
Collaborator Author

@solth apparently, you have to activate the branch hibernate-search at Codacy

@solth
Copy link
Member

solth commented Sep 13, 2023

@solth apparently, you have to activate the branch hibernate-search at Codacy

done

@matthias-ronge
Copy link
Collaborator Author

@solth The CI / build has not been executed though. (I did hope, it would then.) Do you have to enable it as well, or do I need to recreate the pull requests now? Do you know or can you check?

@henning-gerhardt
Copy link
Collaborator

CI will only be trigged in master branch as limited in https://github.com/kitodo/kitodo-production/blob/master/.github/workflows/main.yml#L9-L10 ... maybe removing this limit should fix it

@solth
Copy link
Member

solth commented Oct 10, 2023

@matthias-ronge I think @henning-gerhardt is right. Perhaps you can activate CI for your branch yourself by adding hibernate-search to that line in the .yml file? If not, I would suggest to open a separate PR to change this line in the main.yml file.

Copy link
Member

@solth solth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the branch name to the configuration seems to have had the intended effect, the tests were performaned for this pull request 👍

I would suggest not to remove the whole test, though, but instead just @ignore it until hibernate search is implemented and the mass indexer can be used to manually re-index the system.

@solth solth merged commit 0e1e92d into kitodo:hibernate-search Nov 17, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants