-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hibernate search] Remove test for indexing #5783
Conversation
@solth apparently, you have to activate the branch |
done |
@solth The CI / build has not been executed though. (I did hope, it would then.) Do you have to enable it as well, or do I need to recreate the pull requests now? Do you know or can you check? |
CI will only be trigged in master branch as limited in https://github.com/kitodo/kitodo-production/blob/master/.github/workflows/main.yml#L9-L10 ... maybe removing this limit should fix it |
@matthias-ronge I think @henning-gerhardt is right. Perhaps you can activate CI for your branch yourself by adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding the branch name to the configuration seems to have had the intended effect, the tests were performaned for this pull request 👍
I would suggest not to remove the whole test, though, but instead just @ignore
it until hibernate search is implemented and the mass indexer can be used to manually re-index the system.
This reverts commit 937d7cb.
Issue #5760 1a)