Remove unused statistic button #5798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henning-gerhardt
force-pushed
the
remove_unused_statistic_button
branch
from
4bf339c
to
02b15ff
Compare
|
Sorry for not merging this PR, yet. I am just hesitant because I think we should probably be able to add some useful functionality to this button with the existing functions (like automatically filtering the process list by project and then opening one of the already available statistic popups) which would perhaps be more useful than removing it altogether. |
|
As I don't know who and when this missing functionality is added removing this not functional button is better then have this button and confused users. When this functionality is added back, adding back the button should be a easy task. |
|
You are probably right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5721
Decided to remove the button as needed functionality is not known.