Refactor test framework to load test resources dynamically #5876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markusweigelt
suggested changes
Jan 17, 2024
Kitodo/src/test/java/org/kitodo/production/exporter/download/ExportMetsIT.java
Outdated
Show resolved
Hide resolved
Kitodo/src/test/java/org/kitodo/production/metadata/MetadataEditorIT.java
Outdated
Show resolved
Hide resolved
Kitodo/src/test/java/org/kitodo/production/metadata/MetadataEditorIT.java
Outdated
Show resolved
Hide resolved
Kitodo/src/test/java/org/kitodo/production/metadata/MetadataEditorIT.java
Outdated
Show resolved
Hide resolved
Kitodo/src/test/java/org/kitodo/production/metadata/MetadataEditorIT.java
Outdated
Show resolved
Hide resolved
Kitodo/src/test/java/org/kitodo/production/metadata/MetadataEditorIT.java
Outdated
Show resolved
Hide resolved
Kitodo/src/test/java/org/kitodo/production/services/workflow/WorkflowControllerServiceIT.java
Show resolved
Hide resolved
markusweigelt
suggested changes
Jan 24, 2024
Kitodo/src/test/java/org/kitodo/production/exporter/download/ExportMetsIT.java
Show resolved
Hide resolved
Kitodo/src/test/java/org/kitodo/production/metadata/MetadataEditorIT.java
Outdated
Show resolved
Hide resolved
Kitodo/src/test/java/org/kitodo/production/metadata/MetadataEditorIT.java
Outdated
Show resolved
Hide resolved
markusweigelt
approved these changes
Jan 24, 2024
matthias-ronge
added a commit
to matthias-ronge/kitodo-production
that referenced
this pull request
Jan 26, 2024
matthias-ronge
added a commit
to matthias-ronge/kitodo-production
that referenced
this pull request
Jan 26, 2024
matthias-ronge
added a commit
to matthias-ronge/kitodo-production
that referenced
this pull request
Jan 26, 2024
matthias-ronge
added a commit
to matthias-ronge/kitodo-production
that referenced
this pull request
Jan 26, 2024
matthias-ronge
added a commit
to matthias-ronge/kitodo-production
that referenced
this pull request
Jan 30, 2024
matthias-ronge
added a commit
to matthias-ronge/kitodo-production
that referenced
this pull request
Jan 30, 2024
matthias-ronge
added a commit
to matthias-ronge/kitodo-production
that referenced
this pull request
Feb 2, 2024
matthias-ronge
added a commit
to matthias-ronge/kitodo-production
that referenced
this pull request
Feb 2, 2024
matthias-ronge
added a commit
to matthias-ronge/kitodo-production
that referenced
this pull request
Feb 7, 2024
matthias-ronge
added a commit
to matthias-ronge/kitodo-production
that referenced
this pull request
Feb 7, 2024
matthias-ronge
added a commit
to matthias-ronge/kitodo-production
that referenced
this pull request
Feb 20, 2024
matthias-ronge
added a commit
to matthias-ronge/kitodo-production
that referenced
this pull request
Feb 20, 2024
solth
pushed a commit
that referenced
this pull request
Feb 20, 2024
* Create a base for the Kitodo script * Add a button in the Kitodo Script Dialog * Implement * Add tests * Fix and complete messages * Improve readability * Fix checkstyle * Fix checkstyle * Fix checkstyle * Print meaningful exception * Print meaningful exception manually * Fix a control flow error * Remove error wrapper * Test more generically, and give better error message on failure * Fixes a typo * Fix progress not working * Prevents tasks not being indexed * Support test file arrangement before and after PR #5876 * Fix Javadoc * Remove 'final' modifier from functions used in constructors Since private methods cannot be meaningfully overridden because of their visibility, declaring them final is redundant. * Use Files.walk() with try-with-resources * Invert if-condition * Use Files.walk() with try-with-resource * Invert if-condition * Fix Javadoc * Fix a typo * Spell out abbreviated negations in English * Remove duplicate class 'TreeDeleter' * Fix indent * Reformat try-with-resources statements, remove unnecessary ';' * Rewrite childDepth() to make use of OptionalInt * Fix checkstyle * Rearrange function calls and checks The order of execution of the underlying tasks depends on the order in which they are found on the disk and is unpredictable. Reliable testing is only possible after the end of this group of tasks. * Remove support for test files before PR #5876 * Use 'ProcessTestUtils' for clean-up * Remove database IDs from test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the test framework of Kitodo.Production a little bit by loading test resources like images and metadata for individual tests dynamically. This means the content of static test process directories like
Kitodo/src/test/resources/metadata/2,Kitodo/src/test/resources/metadata/4etc. have been moved to a test resource source directory from which they are loaded at the beginning of the corresponding test.After test execution the test process including its process directory and contents is removed. This ensures processes do not depend on test order and won't accidentally manipulate or remove resources required by other tests. It also makes adding dummy processes to the test database for those static process directories mentioned above obsolte.