Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update location of chrome driver for testing #5923

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

solth
Copy link
Member

@solth solth commented Feb 19, 2024

No description provided.

Copy link
Collaborator

@henning-gerhardt henning-gerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and the selenium tests are working again. Maybe using one of the json end points from https://github.com/GoogleChromeLabs/chrome-for-testing?tab=readme-ov-file#json-api-endpoints (f.e. https://googlechromelabs.github.io/chrome-for-testing/last-known-good-versions-with-downloads.json) for catching the uri's instead of hard coding them? This must not be done yet but maybe in future?

@solth
Copy link
Member Author

solth commented Feb 20, 2024

Good idea! As you can see in the code (

= "https://googlechromelabs.github.io/chrome-for-testing/last-known-good-versions.json";
) we already use one of those JSON endpoints (https://googlechromelabs.github.io/chrome-for-testing/last-known-good-versions.json) to determine the latest version of Chrome, but not to retrieve the complete URL. I will merge this PR so upcoming builds don't fail but will then try if I can implement your suggestion afterwards, if it's no big change.

@solth solth merged commit a956a10 into kitodo:master Feb 20, 2024
2 checks passed
@solth solth deleted the chrome-driver-for-testing branch February 20, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants