Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential input resource leak #5954

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Fix potential input resource leak #5954

merged 2 commits into from
Apr 11, 2024

Conversation

matthias-ronge
Copy link
Collaborator

henning-gerhardt
henning-gerhardt approved these changes Mar 1, 2024
View reviewed changes
Copy link
Collaborator

@henning-gerhardt henning-gerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good and more readable replacement.

solth
solth requested changes Mar 28, 2024
View reviewed changes
Copy link
Member

@solth solth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove imports java.io.BufferedReader, java.util.List and java.util.stream.Collectors from this class, which are not required anymore after this change.

@solth solth merged commit 1e6d5a0 into kitodo:master Apr 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henning-gerhardt henning-gerhardt henning-gerhardt approved these changes

@solth solth solth approved these changes

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthias-ronge @henning-gerhardt @solth