Fix issues reported by Coverity Scan #5995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: 7a612fa ("Update MetadataEditor.java") Signed-off-by: Stefan Weil <[email protected]>
Fixes: 6c6f5cf ("adjust property search, so legacy filters do work") Signed-off-by: Stefan Weil <[email protected]>
|
@Kathrin-Huber, could you please review the change in Kitodo/src/main/java/org/kitodo/production/services/data/FilterService.java? |
stweil
changed the title
| filter.replace("template","property"); | ||
| filter = filter.replace("processproperty","property"); | ||
| filter = filter.replace("workpiece","property"); | ||
| filter = filter.replace("template","property"); |
There was a problem hiding this comment.
The functional equivalent would be to remove this method. We don’t support these search terms any more since a long time.
There was a problem hiding this comment.
If that code implements something which is no longer supported, then removing it is indeed the best solution.
solth
approved these changes
Apr 9, 2024
|
@stweil would you mind opening a corresponding pull request with the same fix against the 3.6.x branch? |
|
Done in PR #6027. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: 7a612fa ("Update MetadataEditor.java")
Fixes: 6c6f5cf ("adjust property search, so legacy filters do work")