[Kitodo Core] Replace Junit 4 with Junit 5 #6093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Kitodo/src/test/java/org/kitodo/production/services/data/ProcessServiceIT.java
Dismissed
Show dismissed
Hide dismissed
Kitodo/src/test/java/org/kitodo/production/services/data/ProcessServiceIT.java
Dismissed
Show dismissed
Hide dismissed
henning-gerhardt
force-pushed
the
replace_junit4_with_junit5_kitodo
branch
from
ca2447e
to
9008d72
Compare
henning-gerhardt
force-pushed
the
replace_junit4_with_junit5_kitodo
branch
2 times, most recently
from
dcbff19
to
044a4d1
Compare
henning-gerhardt
force-pushed
the
replace_junit4_with_junit5_kitodo
branch
from
044a4d1
to
c3de2c7
Compare
henning-gerhardt
force-pushed
the
replace_junit4_with_junit5_kitodo
branch
2 times, most recently
from
8659e1a
to
954440c
Compare
henning-gerhardt
force-pushed
the
replace_junit4_with_junit5_kitodo
branch
from
954440c
to
40b43e9
Compare
solth
requested changes
Jul 30, 2024
There was a problem hiding this comment.
@henning-gerhardt Thanks a lot for this comprehensive update of the JUnit test framework! Found just one(!) little thing to nitpick! (see below)
Kitodo/src/test/java/org/kitodo/production/services/command/CommandServiceTest.java
Outdated
Show resolved
Hide resolved
solth
approved these changes
Jul 31, 2024
This was referenced Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of a pull request series to replace Junit4 with Junit5 based tests. Changed made by module and are independent of the other parts.