Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to show last comment directly in comment column #6150

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

oliver-stoehr
Copy link
Collaborator

@oliver-stoehr oliver-stoehr commented Jul 26, 2024

This pull request adds the option showLastComment to the kitodo-config.properties file.
When set to true this will display the most recent comment in the comments column in the task list and the process list.
This increases the informations the user can retrieve at a glance, without the need to hover over every comment icon.
Bildschirmfoto 2024-07-26 um 09 55 31
This change does not affect the functionality of the enhanced tooltip implemented in #5403. The new option is deactivated by default (the new parameter showLastComment defaults to false if not present).

@stweil
Copy link
Member

stweil commented Jul 26, 2024

The CI failure is unrelated to this PR (see issue #6138).

Copy link
Collaborator

@henning-gerhardt henning-gerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good in general. I tried the your changes without PR #6127 included and they are working for me. Only a small note: my IDE spell checking is telling me that "comments" in all your additions are written wrong. I think that the plural of "comment" is still "comment" and not "comments" but I'm not a language expert.

@solth
Copy link
Member

solth commented Jul 30, 2024

I think that the plural of "comment" is still "comment" and not "comments" but I'm not a language expert.

No, the plural of "comment" is "comments" (see for example https://en.wiktionary.org/wiki/comments#English). I think the IDE incorrectly interprets "comments" as a the - wrong - genitive of "comment" and therefore marks this as an error, even though it's not intended as a genitive, but rather as the plural of "comment" in this context.

@solth solth merged commit 9ed8109 into kitodo:master Jul 30, 2024
5 checks passed
@henning-gerhardt
Copy link
Collaborator

I think that the plural of "comment" is still "comment" and not "comments" but I'm not a language expert.

No, the plural of "comment" is "comments" (see for example https://en.wiktionary.org/wiki/comments#English). I think the IDE incorrectly interprets "comments" as a the - wrong - genitive of "comment" and therefore marks this as an error, even though it's not intended as a genitive, but rather as the plural of "comment" in this context.

Good to know - so ignore my note from my IDE.

@oliver-stoehr oliver-stoehr deleted the last-comment branch August 7, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants