Timeout param and setOptions method and fixed NSLog exception with cordova-ios 6.x.x and iOS 13. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added setOptions method to socket.js. Now from cordova/ionic it's possible to set options directly [Android / iOS]. Removed setSoTimeout with fixed value of 5000 [Android].
Fixed a NSlog error with cordova-ios 6.x.x and iOS 13.
matteocappello94
changed the title
|
@matteocappello94 just wanted to say a drive-by thanks for this patch. Fixes an issue I was facing here!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added timeout param on "open" method [Android].
Added setOptions method to socket.js. Now from cordova/ionic it's possible to set options directly [Android / iOS].
Removed setSoTimeout with fixed value of 5000 [Android].
README file needs to be updated with new method and the installation section with new repository URL.