Update scikit-learn dependency #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will now always use the version by numpy
They are no longer needed, since we no longer support scikit-learn<1.0
kiudee
force-pushed
the
114-update-sklearn
branch
from
fdeec5c
to
57b35ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will now always use the version by numpy
Description
This pull request updates the supported scikit-learn version range to
>=1. In addition, we no longer support python 3.7 and also introduce an upper bound (3.10 is failing the tests).Minor changes to the code were necessary to fix compatibility.
Motivation and Context
See #114
How Has This Been Tested?
Running all tests locally for all supported python versions.
Does this close/impact existing issues?
Closes #114
Types of changes
Checklist: