Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Flake8's W503 #1638

Closed
Julian-O opened this issue Jul 21, 2023 · 1 comment
Closed

Ignore Flake8's W503 #1638

Julian-O opened this issue Jul 21, 2023 · 1 comment

Comments

@Julian-O
Copy link
Contributor

Julian-O commented Jul 21, 2023

Flake8 has a rule: Line break occurred before a binary operator (W503).

By default, Flake8 does not apply this rule, because it is a bad rule, and the Flake8 authors know it:

This rule goes against the PEP 8 recommended style, which was changed on April 16th, 2016 in this commit. The tool will soon be updated to recommend the opposite: line breaks should occur before the binary operator because it keeps all operators aligned.

In January, Buildozer's config was changed to start applying this rule.

This is painful to me, because I use black wherever I can (and heartily recommend Kivy projects move towards adopting it), and black-formatted code does not conform to this rule.

Please remove this rule from the Buildozer config (i.e. return it to the ignore list)

Julian-O added a commit to Julian-O/buildozer that referenced this issue Aug 11, 2023
misl6 pushed a commit that referenced this issue Aug 22, 2023
@misl6
Copy link
Member

misl6 commented Aug 22, 2023

Fixed via #1660

@misl6 misl6 closed this as completed Aug 22, 2023
aorizondo pushed a commit to aorizondo/buildozer that referenced this issue Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants