-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create tests for PR fix bug when logcat value which cannot be decode to utf-8 #857
Comments
Hi. Sadly I don't have enough skills to write tests. I don't know docker (ugly solution) and there is no requirements.txt file to build venv. |
No worries, this could be tricky. command = 'mycommand'
kwargs = { 'show_output': True }
with mock.patch('buildozer.Popen') as m_popen:
# the command output could be were we want to play with unicode decode errors
m_popen().stdout.read.side_effect = [b'mycommand output']
buildozer.cmd(command, **kwargs) That just to give the idea. |
Also fixes stderr/stdout writing introduced in kivy#743.
I just gave it a try see #905 |
…icode_decode Unit test unicode decode on command output, fixes #857
Create tests for fix from link below.
#856
The text was updated successfully, but these errors were encountered: