Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F841: local variable is assigned to but never used #1066

Merged
merged 1 commit into from
Apr 13, 2020

Conversation

AndreMiras
Copy link
Member

No description provided.

@AndreMiras AndreMiras requested a review from opacam April 13, 2020 15:43
mock.patch('os.makedirs'):
ant_path = target._install_apache_ant()
assert ant_path == my_ant_path
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still there, I just to it outside the context manager because it didn't need to be

Copy link
Member

@opacam opacam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, one less exception in our tox.ini file 😄

Thanks!

@AndreMiras
Copy link
Member Author

Thanks for the review/approval, merging!

@AndreMiras AndreMiras merged commit d3361bb into kivy:master Apr 13, 2020
@AndreMiras AndreMiras deleted the feature/linter_F841 branch April 13, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants