Unit tests TargetAndroid.build_package() #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreMiras
changed the title
AndreMiras
force-pushed
the
feature/test_android_build_package
branch
from
b297205
to
6101e99
Compare
AndreMiras
changed the title
opacam
previously approved these changes
Apr 13, 2020
tests/targets/test_android.py
Outdated
Comment on lines
44
to
47
| def patch_os_listdir(): | ||
| return mock.patch("os.listdir") | ||
|
|
||
|
|
There was a problem hiding this comment.
Nice, 4.9% more of coverage 😄
Note: I think that we never use this mock, right?...are you planing to use it later?
There was a problem hiding this comment.
Yes good catch thanks. I actually started using it and decided no to for now.
I've removed it now
Increases android.py coverage from 24% to 36% and total coverage from 25% to 29%. Note that this tests would have caught the glob issue reported in kivy#1044.
AndreMiras
force-pushed
the
feature/test_android_build_package
branch
from
6101e99
to
757941a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increases android.py coverage from 24% to 36% and total coverage from 25% to 29%.
Note that this tests would have caught the glob issue reported in #1044.