Also tests against macOS platform #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreMiras
force-pushed
the
feature/test_on_macos
branch
from
02e7808
to
dfd6662
Compare
opacam
previously approved these changes
Apr 25, 2020
tests/targets/test_android.py
Outdated
| @@ -146,7 +153,8 @@ def test_check_configuration_tokens(self): | |||
| self.target_android.check_configuration_tokens() | |||
| assert m_check_configuration_tokens.call_args_list == [mock.call([])] | |||
|
|
|||
| def test_install_android_sdk(self): | |||
| @pytest.mark.parametrize("platform", ["linux", "darwin",]) | |||
There was a problem hiding this comment.
nitpick: In this case, I think that I would remove the trailing comma
Increases coverage from 28% to 30%.
AndreMiras
force-pushed
the
feature/test_on_macos
branch
from
dfd6662
to
891e24b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increases coverage from 28% to 30%.