Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checks SDK, NDK and p4a get downloaded on first run #1093

Merged
merged 1 commit into from
May 11, 2020
Merged

Checks SDK, NDK and p4a get downloaded on first run #1093

merged 1 commit into from
May 11, 2020

Conversation

AndreMiras
Copy link
Member

calling the p4a command would trigger all the downloads so we can verify it works as expected. Note this phase adds a 1.5 minute overhead

@AndreMiras AndreMiras force-pushed the feature/integration_test_sdk_ndk_download branch from a9725b3 to 8d2a9df Compare May 9, 2020 08:06
@AndreMiras AndreMiras requested a review from opacam May 9, 2020 10:33
AndreMiras added a commit to AndreMiras/buildozer that referenced this pull request May 11, 2020
@AndreMiras
🐛 Fixes missing libssl-dev dependency
d58cd61 
This is required for the minimal build, closes kivy#1096
Integration test will come after kivy#1093 is merged
opacam
opacam approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@opacam opacam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks

AndreMiras added a commit to AndreMiras/buildozer that referenced this pull request May 11, 2020
@AndreMiras
🐛 Fixes missing libssl-dev dependency
9d891b8 
This is required for the minimal build, closes kivy#1096
Integration test will come after kivy#1093 is merged
AndreMiras added a commit to AndreMiras/buildozer that referenced this pull request May 11, 2020
@AndreMiras
🐛 Fixes missing libssl-dev dependency
f2d31cc 
This is required for the minimal build, closes kivy#1096
Also drops Python 2 dependency.
Integration test will come after kivy#1093 is merged
@AndreMiras AndreMiras mentioned this pull request May 11, 2020
Merged
@AndreMiras AndreMiras merged commit 5517322 into kivy:master May 11, 2020
@AndreMiras AndreMiras deleted the feature/integration_test_sdk_ndk_download branch May 11, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opacam opacam opacam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndreMiras @opacam