Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set "UTF-8" to java file.encoding for android update command explicitly #155

Merged
merged 1 commit into from
Oct 26, 2014

Conversation

attakei
Copy link
Contributor

@attakei attakei commented Oct 26, 2014

Hi.

In current version Bulldozer, I have failed to run command "buildozer android debug".
I examined from output exception, and found the next thing.

  • Current(2014/10/25) Android-sdk license is included Non-ASCII characters.
  • There is an environment that is not used UTF-8 to default file.encoding for java (ex: Mac OS in Japanese).
  • In this environment, Android command do output license as Non-UTF8. And Then, Buildozer fail to output characters and raise exception "UnicodeDecodeError".

So I try to fix it.

attakei

Fix for fail in to update android package. It is happened to meet under the following conditions both.

* User environment is not used UTF-8 in default file.encoding in java
* Android-sdk license text is included not-ASCII code characters.

If user define JAVA_TOOL_OPTIONS in env, inherit it.
@attakei attakei changed the title set "UTF-8" to java file.encoding for android update command explicitly Set "UTF-8" to java file.encoding for android update command explicitly Oct 26, 2014
akshayaurora added a commit that referenced this pull request Oct 26, 2014
Set "UTF-8" to java file.encoding for android update command explicitly
@akshayaurora akshayaurora merged commit 89f8f92 into kivy:master Oct 26, 2014
@akshayaurora
Copy link
Member

🎯 nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants