Separate build per android.arch #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevent using the same build (armv7a) when building another arch using profile (arm64-v8a)
SomberNight
added a commit
to spesmilo/electrum
that referenced
this pull request
Aug 31, 2019
- also merge kivy/buildozer#957 as prereq for building multiple apks (one per arch) - and custom buildozer commit to put target arch into apk name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevent using the same build (armv7a) when building another arch using profile (arm64-v8a)
Note: my asumption is that because buildozer pass the storage-dir, p4a assume it is already separated per arch, therefore reuse the same build even if the arch is different. Which is not supposed to happen right?
If this is not supposed to happen, and a fix is applied to p4a, this merge is unecessary.