Fixes test_p4a_recommended_android_ndk_found() mocking #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mocking `for line in open()` should be done via `StringIO`. Also uses `pytest` in `tox.ini` so assert errors are more verbose.
AndreMiras
commented
Oct 5, 2019
| try: | ||
| from unittest import mock # Python 3 | ||
| except ImportError: | ||
| import mock # Python 2 |
There was a problem hiding this comment.
I know you guys like it this way, so I reintroduced it 😄
AndreMiras
commented
Oct 5, 2019
| deps = | ||
| mock | ||
| pytest | ||
| commands = pytest tests/ |
There was a problem hiding this comment.
Basically pytest makes it possible to see exact result of failing comparison. That way we don't need to debug print around in Travis 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mocking
for line in open()should be done viaStringIO.Also uses
pytestintox.iniso assert errors are more verbose.