Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix segfault on hostpython2 when compiling for x86_64 #1351

Merged
merged 1 commit into from
Sep 4, 2018

Conversation

tito
Copy link
Member

@tito tito commented Sep 4, 2018

This is a fixes for #1297 - on some platform, Python < 2.7.15 crashes due to a bug highlighted only with recent compilers.

This one liner came from python/cpython@e348c8d#diff-fb41bdaf12f733cf6ab8a82677d03adc that contains a extensive explaination about it. It could be done on Python 2 for ARM, but the bug isn't triggered at the moment.

I compiled a fresh app with this patch, it doesn't segfault during the compilation of hostpython2, and the app on Android runs.

(I talked about moving to Python 2.7.15, but it would take more time that just accepting this patch, as we would need to update hostpython2 and python2 recipes, and all cross compilation patches. Plus more testing as ssl module changed somewhere, unsure if we don't need more patching to make it work.)

Closes #1297

Copy link
Member

@tshirtman tshirtman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I won't claim I understand all the possible implication of the change myself, but the rational seems sensible, and if it's good enough for python core devs, and has been in production there for half a decade, it's good enough for me 👍

@AndreMiras AndreMiras merged commit 1a42998 into kivy:master Sep 4, 2018
@AndreMiras
Copy link
Member

I didn't test it on Fedora/Arch VM, but it looks good to me, thanks :)

@tito
Copy link
Member Author

tito commented Sep 4, 2018

Thanks you @AndreMiras

@tito tito deleted the fix-hostpython2-segfault branch September 4, 2018 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python2 Build fails with make: *** [Makefile:426: sharedmods] Error 139
3 participants