Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ci_mode to disable download progress #1727

Merged
merged 2 commits into from
Feb 25, 2019
Merged

Conversation

mkg20001
Copy link
Contributor

Otherwise Travis CI complains about log size

Ref kivy/buildozer#823

@AndreMiras
Copy link
Member

Very nice, thank you! May I suggest to directly use something from TravisCI?
https://docs.travis-ci.com/user/environment-variables/#default-environment-variables
What I mean is to replace CI_MODE directly by CI so we don't have to bother setting it in .travis.yml since it's already automatically set by Travis. In a same fashion there's a predefined variable called TRAVIS, but then it feels a bit coupled. If you prefer you can also use the predefined CONTINUOUS_INTEGRATION variable rather than CI, I leave that to you

Otherwise Travis CI complains about log size
@mkg20001
Copy link
Contributor Author

@AndreMiras I've switched to the $CI variable. Both in this pr and kivy/buildozer#833

@mkg20001
Copy link
Contributor Author

I've just noticed: The android SDK installs still continue to spam the logs

screenshot

Would somebody want to look into that?

@AndreMiras
Copy link
Member

Thanks for addressing the comments!
Yes the logs are still showing it because we still need to pass the environment variable from the host to the Docker container. So basically in .travis.yml you can edit the docker run command to add -e CI, so final command should be something like:
docker run -e CI p4a /bin/sh -c "$COMMAND"

That commit message ^^
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@AndreMiras AndreMiras merged commit 8ebea2e into kivy:master Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants