Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix libffi recipe, and build + runtime linker errors when compiling on WSL #1744

Merged
merged 8 commits into from
Mar 20, 2019
Merged

Fix libffi recipe, and build + runtime linker errors when compiling on WSL #1744

merged 8 commits into from
Mar 20, 2019

Commits on Mar 8, 2019

  1. Fix libffi linker errors when compiling on WSL 

    Force the use of lld (LLVM's linker), and include a python37 bugfix.
https://clang.llvm.org/docs/Toolchain.html
https://lld.llvm.org/
https://bz-attachments.freebsd.org/attachment.cgi?id=200526
    @Aralox
    Aralox committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    36a99c4 View commit details
    Browse the repository at this point in the history

  2. Remove lld unsupported fix-cortex-a8 from LDFLAGS 

    android/ndk#313
android/ndk#766
https://developer.android.com/ndk/guides/standalone_toolchain
    @Aralox
    Aralox committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    f9d7bbb View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2019

  1. Fix libffi recipe, runtime libffi linker errors. 

    Libtool didnt like the space after --sysroot, replaced with =
    @Aralox
    Aralox committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    9cfcb03 View commit details
    Browse the repository at this point in the history

  2. Appease flake8

    @Aralox
    Aralox committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    f1ca66d View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2019

  1. CRAs - Check for lld before using it. 

    Changed hardcoded cpu count to cpu_count().
Added comment to python patch.
Made remove-fix-cortex-a8.patch conditional on lld.
Moved LDFLAGS change to get_recipe_env() so its not libffi specific
within python.py.
    @Aralox
    Aralox committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    696e88f View commit details
    Browse the repository at this point in the history

  2. Replaced subprocess.getstatusoutput with sh.which 

    for python2 compatibility.
    @Aralox
    Aralox committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    93d2e12 View commit details
    Browse the repository at this point in the history

  3. Seriously tox?

    @Aralox
    Aralox committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    0c2a2c5 View commit details
    Browse the repository at this point in the history

  4. Update Dockerfile revert lld dep

    @AndreMiras
    AndreMiras authored Mar 20, 2019
    Configuration menu
    Copy the full SHA
    8202e4d View commit details
    Browse the repository at this point in the history