Merge pull request #475 from kiwicom/timeline-past-warning-critical-g…

…radient-to-success

Timeline: fix going to success from past critical/warning

ui/src/main/java/kiwi/orbit/compose/ui/controls/Timeline.kt

@@ -272,14 +272,7 @@ private fun ItemLine(
     val width = with(LocalDensity.current) {
         20.sp.toDp()
     }
-    if (status in setOf(
-            TimelineItemStatus.InProgress,
-            TimelineItemStatus.CurrentSuccess,
-            TimelineItemStatus.CurrentWarning,
-            TimelineItemStatus.CurrentCritical,
-            TimelineItemStatus.Future,
-        )
-    ) {
+    if (status in TimelineItemStatusWithDashedBottomLine) {
         val color = OrbitTheme.colors.surface.normalAlt
         Canvas(modifier = Modifier.width(width)) {
             drawLine(
@@ -308,20 +301,12 @@ private fun ItemLine(
 private fun ItemTopLineGradient(
     status: TimelineItemStatus,
 ) {
-    if (status in setOf(
-            TimelineItemStatus.PastSuccess,
-            TimelineItemStatus.InProgress,
-            TimelineItemStatus.CurrentSuccess,
-            TimelineItemStatus.Future,
-        )
-    ) {
+    if (status in TimelineItemStatusWithGradientTopLine) {
         Box {}
         return
     }
 
-    val width = with(LocalDensity.current) {
-        20.sp.toDp()
-    }
+    val width = with(LocalDensity.current) { 20.sp.toDp() }
     val color = status.color
     val gradient = Brush.linearGradient(colors = listOf(Color.Transparent, color))
     Canvas(modifier = Modifier.width(width)) {
@@ -347,6 +332,19 @@ private val TimelineItemStatus.color: Color
         TimelineItemStatus.Future -> OrbitTheme.colors.surface.normalAlt
     }
 
+private val TimelineItemStatusWithDashedBottomLine = setOf(
+    TimelineItemStatus.InProgress,
+    TimelineItemStatus.CurrentSuccess,
+    TimelineItemStatus.CurrentWarning,
+    TimelineItemStatus.CurrentCritical,
+    TimelineItemStatus.Future,
+)
+
+private val TimelineItemStatusWithGradientTopLine = setOf(
+    TimelineItemStatus.InProgress,
+    TimelineItemStatus.Future,
+)
+
 @OrbitPreviews
 @Composable
 internal fun TimelinePreview() {
@@ -413,6 +411,10 @@ internal fun TimelineStatesPreview() {
                 status = TimelineItemStatus.PastWarning,
                 title = { Text("Waiting for the airline even more") },
             )
+            TimelineItem(
+                status = TimelineItemStatus.PastSuccess,
+                title = { Text("Something good happened") },
+            )
             TimelineItem(
                 status = TimelineItemStatus.CurrentCritical,
                 title = { Text("Waiting for the airline, the last one") },