Migrate Tile to Tailwind #4101
Merged
Migrate Tile to Tailwind #4101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -1.04 kB (0%) Total Size: 472 kB
ℹ️ View Unchanged
|
Deploying with
|
| Latest commit: |
9bbbec0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://62b0c537.orbit.pages.dev |
| Branch Preview URL: | https://oreqizer-tw-tile.orbit.pages.dev |
oreqizer
force-pushed
the
oreqizer/tw-tile
branch
4 times, most recently
from
fa8173d
to
cf5d184
Compare
oreqizer
force-pushed
the
oreqizer/tw-tile
branch
2 times, most recently
from
ef9b71c
to
8137f4d
Compare
DSil
requested changes
Oct 23, 2023
packages/orbit-components/src/Tile/components/TileWrapper/index.tsx
Outdated
Show resolved
Hide resolved
packages/orbit-components/src/Tile/components/TileWrapper/index.tsx
Outdated
Show resolved
Hide resolved
packages/orbit-components/src/Tile/components/TileHeader/index.tsx
Outdated
Show resolved
Hide resolved
|
Also, unit tests are failing on this components, so please address that 🙏 |
oreqizer
force-pushed
the
oreqizer/tw-tile
branch
from
8137f4d
to
c148ff7
Compare
oreqizer
force-pushed
the
oreqizer/tw-tile
branch
from
082f459
to
d41e9a6
Compare
DSil
reviewed
Oct 24, 2023
packages/orbit-components/src/Tile/components/TileWrapper/index.tsx
Outdated
Show resolved
Hide resolved
DSil
reviewed
Oct 24, 2023
packages/orbit-components/src/Tile/components/TileWrapper/index.tsx
Outdated
Show resolved
Hide resolved
oreqizer
force-pushed
the
oreqizer/tw-tile
branch
2 times, most recently
from
e8bbcfa
to
c354b8b
Compare
mainframev
suggested changes
Oct 25, 2023
| @@ -1,16 +1,12 @@ | |||
| import * as React from "react"; | |||
| import styled, { css } from "styled-components"; | |||
| import clsx from "clsx"; | |||
There was a problem hiding this comment.
Suggested change
| import clsx from "clsx"; | |
| import cx from "clsx"; |
| )} | ||
| </Stack> | ||
| ))} | ||
| {!noHeaderIcon && ( | ||
| <StyledIconRight external={external} expandable={expandable} expanded={expanded} /> | ||
| <IconRight | ||
| className={clsx( |
There was a problem hiding this comment.
Suggested change
| className={clsx( | |
| className={cx( |
|
|
||
| import mq from "../../../utils/mediaQuery"; | ||
| import defaultTheme from "../../../defaultTheme"; | ||
| import clsx from "clsx"; |
There was a problem hiding this comment.
just 💅🏻 , we use it everywhere as import cx from "clsx" :)
Suggested change
| import clsx from "clsx"; | |
| import cx from "clsx"; |
| withPointer={withPointer} | ||
| withBorder={withBorder} | ||
| useMargins={useMargins} | ||
| className={clsx( |
There was a problem hiding this comment.
Suggested change
| className={clsx( | |
| className={cx( |
DSil
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Non-blocking, but I would say we don't need separate commit messages for sub-components, since they are not exported. Ultimately, what's relevant for the user reading the changelog notes is that the Tile component (the only one they have access to) is migrated to Tailwind. But it's a detail, so LGTM 👍
oreqizer
force-pushed
the
oreqizer/tw-tile
branch
2 times, most recently
from
5382d13
to
51d864d
Compare
|
Did you run chromatic post-migration? |
oreqizer
force-pushed
the
oreqizer/tw-tile
branch
from
51d864d
to
9bbbec0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://kiwicom.atlassian.net/browse/FEPLT-1701
Storybook: https://orbit-mainframev-oreqizer-tw-tile.surge.sh
Chromatic visual test: https://www.chromatic.com/build?appId=6523bafdbc6087c220b3cc48&number=148