-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add accessibility props to Seat #4512
Open
DSil
wants to merge
4
commits into
master
Choose a base branch
from
dsil/add-a11y-seat
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+95
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: `title` and `description` props no longer have default values. They can be manually set with text to be announced by screen readers.
It receives a string of id(s)
DSil
force-pushed
the
dsil/add-a11y-seat
branch
from
November 7, 2024 16:02
7e881a9
to
000462e
Compare
Deploying orbit with Cloudflare Pages
|
Storybook staging is available at https://kiwicom-orbit-dsil-add-a11y-seat.surge.sh |
Size Change: +10 B (0%) Total Size: 459 kB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal for adding accessibility to Seat component.
New prop
aria-labelledby
added to Seat component. Thetitle
anddescription
props no longer have default values (Breaking change).New prop
aria-label
added to SeatLegend component.New accessibility documentation page added for Seat component.