Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of binaryData .url keys #251

Merged
merged 5 commits into from
Jan 23, 2023

Conversation

svolland-csgroup
Copy link
Contributor

This fixes issue #250

Copy link
Member

@jekkel jekkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! The fixes look good. Could you please add reproducers for both issues to the test in the github workflow?

@svolland-csgroup
Copy link
Contributor Author

Tests added, in fact it is only one issue (by fixing only the first point you hit the second point. Both are fixed)

jekkel
jekkel previously approved these changes Jan 20, 2023
test/resources/resources.yaml Outdated Show resolved Hide resolved
@svolland-csgroup
Copy link
Contributor Author

You're right it could also mess up with branch builds, I didn't see there already was a local server. Fixed :)

jekkel
jekkel previously approved these changes Jan 20, 2023
Copy link
Member

@jekkel jekkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jekkel
Copy link
Member

jekkel commented Jan 20, 2023

Run cp test/kubelogo.png test/server/static/
cp: cannot stat 'test/kubelogo.png': No such file or directory
Error: Process completed with exit code 1.

see here

@svolland-csgroup
Copy link
Contributor Author

Not sure about this fix, i'm completely new to github workflows...

@jekkel jekkel added the bug Something isn't working label Jan 23, 2023
@jekkel jekkel merged commit b2101c9 into kiwigrid:master Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants