-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix handling of binaryData .url keys #251
Fix handling of binaryData .url keys #251
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! The fixes look good. Could you please add reproducers for both issues to the test in the github workflow?
Tests added, in fact it is only one issue (by fixing only the first point you hit the second point. Both are fixed) |
You're right it could also mess up with branch builds, I didn't see there already was a local server. Fixed :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
see here |
Not sure about this fix, i'm completely new to github workflows... |
This fixes issue #250