Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: ErrorActivity was not appearing in the non-debug version when the application crashed. #3621

Merged
merged 1 commit into from
Dec 23, 2023

Conversation

MohitMaliFtechiz
Copy link
Collaborator

Fixes #3620

  • We are using the applicationContext to start the ErrorActivity, which is outside the Activity. Therefore, to initiate the activity with an external context of the Activity, we must include the FLAG_ACTIVITY_NEW_TASK flag in the intent. Without this flag, the activity will not start.
screen-20231220-174803.mp4

@MohitMaliFtechiz MohitMaliFtechiz added this to the 3.9.1 milestone Dec 20, 2023
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (fa3e2d1) 48.75% compared to head (3783801) 48.78%.

❗ Current head 3783801 differs from pull request most recent head f7e1416. Consider uploading reports for the commit f7e1416 to get more accurate results

Files Patch % Lines
...rg/kiwix/kiwixmobile/core/main/CoreMainActivity.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3621      +/-   ##
============================================
+ Coverage     48.75%   48.78%   +0.02%     
- Complexity     1091     1093       +2     
============================================
  Files           285      285              
  Lines         10556    10568      +12     
  Branches       1413     1413              
============================================
+ Hits           5147     5156       +9     
- Misses         4569     4572       +3     
  Partials        840      840              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…the application crashed.

* We are using the `applicationContext` to start the `ErrorActivity`, which is outside the `Activity`. Therefore, to initiate the activity with an external context of the `Activity`, we must include the `FLAG_ACTIVITY_NEW_TASK` flag in the intent. Without this flag, the activity will not start.
@kelson42 kelson42 merged commit c670076 into main Dec 23, 2023
6 of 7 checks passed
@kelson42 kelson42 deleted the Issue#3620 branch December 23, 2023 09:25
@kelson42 kelson42 removed this from the 3.9.1 milestone Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ErrorActivity is not showing in non-debug version when the application is crashing.
3 participants