-
-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgraded webkit
version to latest to work with latest chromium
dependencies.
#3648
Conversation
…ndencies. * Upgraded the `WebKit` version to the latest (from 1.3.0 to 1.7.0) to leverage improvements and bug fixes. This update is essential to address the issue with the latest `chromium` dependency, as outlined in #3644. * Additionally, elevated the `androidx.annotation:annotation` dependency from `1.1.0` to `1.2.0` to meet the requirements of the updated WebKit version.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3648 +/- ##
============================================
- Coverage 48.69% 48.64% -0.06%
Complexity 1090 1090
============================================
Files 285 285
Lines 10564 10573 +9
Branches 1415 1417 +2
============================================
- Hits 5144 5143 -1
- Misses 4579 4587 +8
- Partials 841 843 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MohitMaliFtechiz We need to change the parameters of the new API.
@gouri-panda Which new API? Are you talking about updating all the dependencies according to our compiled SDK version? |
@MohitMaliFtechiz For some reason the string files doesn't compile to the recent versions even though we haven't changed here. So I guess the new SDK cause there.
|
@gouri-panda Now I got your point. No, it is not related to the new SDK, We have implemented #3625 after that this error came because the previous translations had been already merged. I already placed a fix for it on |
@MohitMaliFtechiz Do zimit still work properly? It does not i play to stop supporting older versions of Android? |
@kelson42 Yes it is working with Zimit files, I have tested it on Android 8, Android 12, and Android 13. On Android 8 On Android 12 ZimitFilesOnAndroid12.mp4 |
Fixes #3644
WebKit
version to the latest (from 1.3.0 to 1.7.0) to leverage improvements and bug fixes. This update is essential to address the issue with the latestchromium
dependency, as outlined inExceptionInInitializerError
reported by the play store #3644.androidx.annotation:annotation
dependency from1.1.0
to1.2.0
to meet the requirements of the updated WebKit version.