Fixed: Content labeling issue reported by the playstore. #3707
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3700
Child Issue #3680
contentDescription
for views, which are shown in the below images, if you have any better suggestions for thesecontentDescripton
, it would be welcome.navigationIcon
from toolbar. So we make a helper function to get that view. Please read the code comments as this change has some conditions after closing some screens. For example, we previously changed this icon/contentDescription to the "+" button when opening the tabSwitcher. After closing the tabSwitcher, we reset the contentDescription to the default hamburger icon. To properly understand all the changes we have added appropriate comments on methods.ActionMode
back button, there is no way I found yet to get the view so the description is not set for that (Might be that's why Play Store does not report for this view.).ActionMode
activates, when you select one or more things(Zim files, history, etc) to delete. If you have any suggestions it would be welcome.navigationBackButton
means it removes thecontentDecripton
from thenavigationBackButton
so it does not show when the searchView is activated but after searchView is closed it starts working normally. You can see this behavior in theBookmarks
screen, just a long click on the backButton when initially launching the screen you will see the description, after that click on the search icon and again try to long click on the back button you will not see the description. SearchView does not have its own backButton it internally overrides the behaviour ofnavigationBackButton
.