Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: Play Store reported a crash error when closing the tabs. #3791

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Fixed: Play Store reported a crash error when closing the tabs. #3791

merged 2 commits into from
Apr 17, 2024

Commits on Apr 17, 2024

  1. Fixed: Play Store reported a crash error when closing the tabs. 

    * This error was occurring due to the user frequently clicking the close icon of the same tab, in this situation first click closes the tab, and the second immediate click again triggers the `closeTab` function but recyclerView does not have the valid view for this position because it is in removing process so this makes this view invalid and recyclerView returns the `-1` index for invalid views. So this was the reason for this issue, to address this issue we have added a check in our `closeTab` method if the incoming index is `-1` then it will not execute the further code.
    @MohitMaliDeveloper @kelson42
    MohitMaliDeveloper authored and kelson42 committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    dda2200 View commit details
    Browse the repository at this point in the history

  2. Enhanced the Tab closed snackBar behavior. Now, when the user click… 

    …s the `UNDO` button to restore a tab, we disable the snackBar's "UNDO" button to prevent subsequent clicks. This prevents the addition of multiple tabs if the `UNDO` button is clicked multiple times, as this type of restored tab leads to unexpected behavior see below video.
    @MohitMaliDeveloper @kelson42
    MohitMaliDeveloper authored and kelson42 committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    40e86d0 View commit details
    Browse the repository at this point in the history