Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded the minimum SDK version to 25. #3840

Merged
merged 3 commits into from
May 13, 2024
Merged

Upgraded the minimum SDK version to 25. #3840

merged 3 commits into from
May 13, 2024

Conversation

MohitMaliFtechiz
Copy link
Collaborator

@MohitMaliFtechiz MohitMaliFtechiz commented May 13, 2024

Fixes #3783

  • Updated the README.md file for this new change.
  • Removed the API level 24 from CI and added the API level 25 since now our minimum SDK version is 25.
  • Renamed CompatV24 file since we have upgraded the minimum SDK version so this fileName was irrelevant.
  • Added the heap size in the API level 25 emulator.

* Updated the `README.md` file for this new change.
* Removed the API level 24 from CI and added the API level 25 since now our minimum SDK version is 25.
* Renamed CompatV24 file since we have upgraded the minimum SDK version so this fileName was irrelevant.
@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as draft May 13, 2024 07:37
Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 53.77%. Comparing base (c03c376) to head (4256247).

Files Patch % Lines
...ava/org/kiwix/kiwixmobile/core/compat/CompatV33.kt 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #3840   +/-   ##
=========================================
  Coverage     53.76%   53.77%           
+ Complexity     1321     1320    -1     
=========================================
  Files           292      292           
  Lines         11078    11078           
  Branches       1471     1471           
=========================================
+ Hits           5956     5957    +1     
+ Misses         4136     4134    -2     
- Partials        986      987    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as ready for review May 13, 2024 14:07
@kelson42 kelson42 merged commit 2612cf8 into main May 13, 2024
9 of 10 checks passed
@kelson42 kelson42 deleted the Fix#3783 branch May 13, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Minimum SDK version to 25
3 participants