Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use java-libkiwix 2.2.0 #3867

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Use java-libkiwix 2.2.0 #3867

merged 2 commits into from
Jun 7, 2024

Conversation

MohitMaliFtechiz
Copy link
Collaborator

@MohitMaliFtechiz MohitMaliFtechiz commented Jun 7, 2024

  • We have the new version available for java-libkiwix that fixes the crash scenarios on arm architecture.
  1. [libm.so] __gnu_Unwind_Resume #3661
  2. Kiwix 3.9.1 and Wikivoyage 2023-12 apps crashing when opening zim files on Fire OS 7.3.2.9 #3692
    and many more crashes reported by the playStore.
  • In version 2.2.0 we have added the support for SDK 34, and we have upgraded the gradle along with the kotlin version. Our current SDK is 33 which is lower than the library version, and it uses the lower kotlin version that is conflicting in the project. So to fix this issue, we have excluded the kotlin lib from the library so that it will use the project kotlin version. We will remove this excluding after we upgrade our application SDK 34.

@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as draft June 7, 2024 07:23
@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as ready for review June 7, 2024 07:46
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.59%. Comparing base (f17e3f9) to head (1bff4b9).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3867      +/-   ##
============================================
+ Coverage     53.55%   53.59%   +0.03%     
- Complexity     1395     1397       +2     
============================================
  Files           301      301              
  Lines         11552    11552              
  Branches       1520     1520              
============================================
+ Hits           6187     6191       +4     
+ Misses         4368     4366       -2     
+ Partials        997      995       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42 kelson42 merged commit 42f20ea into main Jun 7, 2024
10 checks passed
@kelson42 kelson42 deleted the use_java_libkiwix_2.2.0 branch June 7, 2024 08:26
@stefan-inf
Copy link

Hi, is there a new Kiwix version (with the new lib) which I could test? I am the guy with issue #3600 (V3.8.1 crashes when opening zim files).

@kelson42
Copy link
Collaborator

kelson42 commented Jun 7, 2024

@stefan-inf Version 3.11 will be put in testing today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants