-
-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed: Xapian crash scenarios. #3885
Commits on Jun 18, 2024
-
Fixed: Xapian crash scenarios.
* Enhanced retrieval of suggestion lists from libzim. * Implemented task cancellation if the fragment is not visible. * Refactored getVisibleResults into a suspend method to ensure efficient job cancellation. * Handled exceptions thrown by coroutines. * Transitioned to Kotlin Flow instead of Flowable after making getVisibleResults suspend. * Employed lifecycleScope for coroutine launch to prevent unnecessary calls when the fragment is hidden.
Configuration menu - View commit details
-
Copy full SHA for 8865aac - Browse repository at this point
Copy the full SHA 8865aacView commit details
Commits on Jun 19, 2024
-
Improved the
getVisibleResults
method to check if the current job i……s cancelled before requesting suggestion results from libzim. * Enhanced the loadMoreSearchResults method to accommodate this modification. * Refined the render method to effectively cancel any previously running tasks upon its subsequent execution.
Configuration menu - View commit details
-
Copy full SHA for c405025 - Browse repository at this point
Copy the full SHA c405025View commit details -
Moved the global mutex to the SearchResultsWithTerm class to prevent …
…concurrency issues. * Applied mutex locking in the SearchState class to ensure safe access to search results when users search for different terms.
Configuration menu - View commit details
-
Copy full SHA for 9875ad5 - Browse repository at this point
Copy the full SHA 9875ad5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1dfac37 - Browse repository at this point
Copy the full SHA 1dfac37View commit details -
Configuration menu - View commit details
-
Copy full SHA for e993437 - Browse repository at this point
Copy the full SHA e993437View commit details -
Configuration menu - View commit details
-
Copy full SHA for eb95bdd - Browse repository at this point
Copy the full SHA eb95bddView commit details -
Added instrumentation test cases to test the search functionality.
* Testing the render method with different scenarios to ensure that libzim do not crash due to broken call stack.
Configuration menu - View commit details
-
Copy full SHA for 1fcbe67 - Browse repository at this point
Copy the full SHA 1fcbe67View commit details -
Configuration menu - View commit details
-
Copy full SHA for 193c0d1 - Browse repository at this point
Copy the full SHA 193c0d1View commit details