Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: A NotSerializableException was attached to the crash logs instead of the actual crash logs when there was an error in the coroutine. #3904

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

MohitMaliFtechiz
Copy link
Collaborator

@MohitMaliFtechiz MohitMaliFtechiz commented Jun 27, 2024

Fixes #3901
Fixes #3902

  • The serialization issue was fixed in coroutine version 1.7.0, so we have upgraded the coroutine dependency to 1.7.3 to address this issue.
  • In the new version of coroutines, ConflatedBroadcastChannel is replaced with StateFlow, so we have refactored our code to use StateFlow.
  • Fixed some detekt issues which occur after upgrading this dependency.

…stead of the actual crash logs when there was an error in the coroutine.

* The serialization issue was fixed in coroutine version `1.7.0`, so we have upgraded the coroutine dependency to `1.7.0` to address this issue.
* In the new version of coroutines, `ConflatedBroadcastChannel` is replaced with `StateFlow`, so we have refactored our code to use `StateFlow`.
* Fixed some detekt issues which occurs after upgrading this dependency.
@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as draft June 27, 2024 09:30
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 53.58%. Comparing base (e4c3d1a) to head (0d5a330).

Files Patch % Lines
.../org/kiwix/kiwixmobile/core/error/ErrorActivity.kt 0.00% 7 Missing ⚠️
...wixmobile/core/search/viewmodel/SearchViewModel.kt 85.71% 0 Missing and 1 partial ⚠️
...va/org/kiwix/kiwixmobile/core/utils/ServerUtils.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3904      +/-   ##
============================================
- Coverage     53.59%   53.58%   -0.02%     
  Complexity     1404     1404              
============================================
  Files           302      302              
  Lines         11602    11605       +3     
  Branches       1530     1530              
============================================
  Hits           6218     6218              
- Misses         4384     4388       +4     
+ Partials       1000      999       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as ready for review June 27, 2024 11:25
@kelson42 kelson42 merged commit 262b4e5 into main Jun 27, 2024
9 of 10 checks passed
@kelson42 kelson42 deleted the Fixes#3901 branch June 27, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants